Support adaptive background thresholding for Xenium data via stain_bg_percentile argument#22
Open
katwre wants to merge 2 commits intochenhcs:mainfrom
Open
Support adaptive background thresholding for Xenium data via stain_bg_percentile argument#22katwre wants to merge 2 commits intochenhcs:mainfrom
katwre wants to merge 2 commits intochenhcs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi hi,
I wanted to share my experience running SCS on 10x Xenium data - I'm trying to add it to the nf-core spatialxe pipeline ( nf-core/spatialxe#130 ). I found that the default background threshold (stain_bg_threshold=10) does not work well for Xenium data, since almost all pixels have values above 10. This results in no background being detected and the model failing to train properly. That's a pull request related to the issue I just opened #21 . Please find in the attachment my test code Test_SCS2Visium.ipynb using the breast cancer tumor Xenium data (https://www.10xgenomics.com/products/xenium-in-situ/preview-dataset-human-breast), and the screenshot of the results:
I hope it's fine that I prepared a pull request to adjust for that. Summary of changes:
Let me know if you'd like any further changes. Thanks for maintaining SCS!
Cheers,
Kasia